feat: removing s3 async client and adding aal vector path#5
Closed
feat: removing s3 async client and adding aal vector path#5
Conversation
stubz151
force-pushed
the
remove_async_client
branch
from
24ca344 to
004940f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Am I doing
Removing the async client which AAL added in pr's:
I am doing this because after testing/benchmarking and speaking with the teams involved, this is not a suitable use-case for the s3 async client so I am removing it.
I am also implementing the range readable interface on the AAL adapter to make better use of the new api's we have added
How have I tested it
TODO, I still need to update some of the integ/unit tests.